Aaron Schulz [Wed, 14 Sep 2016 07:10:11 +0000 (00:10 -0700)]
Move LoadMonitor classes to libs/rdbms/loadmonitor
Change-Id: Ib18108f24ff8b9d05dc324bad132f597b3e2ddef
Aaron Schulz [Wed, 14 Sep 2016 02:38:19 +0000 (19:38 -0700)]
Replace some MWExceptions with natives ones in /db
Change-Id: I94532d09216926d401e94c61acd60fdc6241a2a0
Aaron Schulz [Wed, 14 Sep 2016 05:49:10 +0000 (22:49 -0700)]
Use cpPosTime cookie for same-domain redirects on DB change
This follows-up
a3dacac90f to show the URL parameter in less cases.
Change-Id: Ibe015352962fb3ee14d5aa322f0e748ef4cba5c1
Aaron Schulz [Wed, 14 Sep 2016 01:18:37 +0000 (18:18 -0700)]
Add ILoadBalancer interface
Remove redundant LoadBalancer docs (those without @since).
Change-Id: I981177b6854cfdbea4a51b6db7e365dac0da258a
jenkins-bot [Wed, 14 Sep 2016 02:34:10 +0000 (02:34 +0000)]
Merge "Convert LoadBalancer/Database class logging to PSR"
Aaron Schulz [Mon, 12 Sep 2016 22:10:16 +0000 (15:10 -0700)]
Convert LoadBalancer/Database class logging to PSR
Reorder DatabaseBase constructor/factory to the top.
Change-Id: I2ffff950b9170d6ff15dcd46b64dd366f1e441a8
jenkins-bot [Wed, 14 Sep 2016 01:48:39 +0000 (01:48 +0000)]
Merge "Partially reverting I8e684f06 to restore some legacy behavior"
jenkins-bot [Wed, 14 Sep 2016 01:45:02 +0000 (01:45 +0000)]
Merge "Move PECL memcached class to /libs"
Kaldari [Wed, 14 Sep 2016 01:24:55 +0000 (18:24 -0700)]
Partially reverting I8e684f06 to restore some legacy behavior
Apparently some calls to getDateCond() expect it to not set an offset.
Also, removing some of the new tests that no longer work since they
don't pass all the required parameters. (Before I8e684f06, the year
and month were both required parameters.)
Bug: T145597
Change-Id: I3a90b3da48e49ec9723b7100a7d92146154f74e3
jenkins-bot [Wed, 14 Sep 2016 01:05:58 +0000 (01:05 +0000)]
Merge "Various dependency injection cleanups to LoadBalancer"
Kunal Mehta [Wed, 14 Sep 2016 00:22:44 +0000 (17:22 -0700)]
ParserTests: Make sure WikiPage::doEditContent() succeeds
If a parser test tries to create a page with invalid content (rejected
by Content::prepareSave() or Content::isValid()), throw an exception
instead of silently failing.
Change-Id: I89642604216699f27884120b3c297a0b277c47a6
jenkins-bot [Wed, 14 Sep 2016 00:22:15 +0000 (00:22 +0000)]
Merge "Make sure emails from RecentChange::save() are for comitted rows"
Aaron Schulz [Sun, 11 Sep 2016 21:57:09 +0000 (14:57 -0700)]
Various dependency injection cleanups to LoadBalancer
* Inject wfWikiID() and MWExceptionHandler into LoadBalancer.
* Factor out LBFactory duplication into baseLoadBalancerParams().
* Remove $wgDBtype hack. Presumably, sites with others DBs would
not have multiple servers configured if does not work anyway.
* Make use of injected TransactionProfiler rather than calling
Profiler::instance()->getTransactionProfiler().
* Avoid use of trivial wfSplitWikiID() function.
* Make DBConnRef enforce its arguments more strongly and
optimize getWiki() to avoid causing a connection attempt.
* Avoid deprecated method call in LBFactory::destroyInstance().
Change-Id: If134b62d4f48cd68cb48ccbe149e72f12aa26819
jenkins-bot [Tue, 13 Sep 2016 22:26:26 +0000 (22:26 +0000)]
Merge "Remove pointless double exception logging from JobRunner"
jenkins-bot [Tue, 13 Sep 2016 21:58:58 +0000 (21:58 +0000)]
Merge "momentjs: Hack around bug in node/browser compat wrapper in locale files"
Chad Horohoe [Tue, 13 Sep 2016 21:07:32 +0000 (14:07 -0700)]
Avoid warnings when unable to parse the URL given to us
Change-Id: I56f1f36a3a54c6c23579f011d65dc75f30cb6dcf
Translation updater bot [Tue, 13 Sep 2016 20:14:01 +0000 (22:14 +0200)]
Localisation updates from https://translatewiki.net.
Change-Id: I1c1a5601f4e102c7c8ac32908c91f5f3cff25eaa
James D. Forrester [Tue, 13 Sep 2016 18:48:04 +0000 (11:48 -0700)]
Update OOjs UI to v0.17.9
Release notes:
https://phabricator.wikimedia.org/diffusion/GOJU/browse/master/History.md;v0.17.9
Change-Id: Ibe5ba723888646f48ab4be9b88bc7a16ee0ae054
jenkins-bot [Tue, 13 Sep 2016 16:06:00 +0000 (16:06 +0000)]
Merge "Fix some PhpStorm warnings in AuthManager"
Paladox [Sun, 11 Sep 2016 17:26:36 +0000 (18:26 +0100)]
Remove jquery.arrowSteps module
It was unused by any other extension
https://github.com/search?q=user%3Awikimedia+jquery.arrowSteps&ref=searchresults&type=Code&utf8=%E2%9C%93
and only used for UploadWizard so it was merged into there with
I054674c7025ad37a8592ca82ce7ce0efd41d393f
Depends-On: I054674c7025ad37a8592ca82ce7ce0efd41d393f
Bug: T144974
Change-Id: Id9b6af1f1774bc33ceb024126030eefdc43beba0
Kunal Mehta [Tue, 13 Sep 2016 10:44:08 +0000 (03:44 -0700)]
ChangeTags: Rename "extension" to "software"
Most end users don't care about whether a tag comes from MediaWiki core
or an extension. Since we now have tags that are added by core, let's
rename all of the "extension" terminology to the more generic
"software".
Not renamed in this patch is the i18n message "tags-source-extension",
which will be done in a separate patch to coordinate with TWN, and the
"source" output of the API, to avoid a breaking change.
Change-Id: Ic7b32b3e4bef0c0153a7cf302eef4aa07c52c9f2
jenkins-bot [Tue, 13 Sep 2016 11:42:44 +0000 (11:42 +0000)]
Merge "Add a change tag for edits that change the content model of a page"
jenkins-bot [Tue, 13 Sep 2016 11:41:59 +0000 (11:41 +0000)]
Merge "ChangeTags: Skip caching if some hooks aren't registered"
Kunal Mehta [Tue, 13 Sep 2016 07:10:08 +0000 (00:10 -0700)]
Add a change tag for edits that change the content model of a page
And adjust the 'tags-source-extension' message to indicate that tags are
not just defined by extensions, but the software in general. The
extension related functions will be renamed in a follow-up patchset.
Bug: T145344
Change-Id: Id4391bc100287b8e469636949eaf7845bbd1d67c
Kunal Mehta [Tue, 13 Sep 2016 09:18:08 +0000 (02:18 -0700)]
Fix typo in "editpage-invalidcontentmodel-text" message
Bug: T145491
Change-Id: I1814a84d49f6cf837f18a1e6e5b3db9602e1f55c
jenkins-bot [Tue, 13 Sep 2016 08:05:18 +0000 (08:05 +0000)]
Merge "Add day to date filter for ReverseChronologicalPager"
Kunal Mehta [Tue, 13 Sep 2016 06:32:06 +0000 (23:32 -0700)]
ChangeTags: Skip caching if some hooks aren't registered
There is caching around the ChangeTagsListActive and ListDefinedTags
hooks that can be skipped if no callers are registered for them.
Change-Id: I0c8fccc358f80536fff7ad0bda1cab09181bca41
jenkins-bot [Tue, 13 Sep 2016 06:40:52 +0000 (06:40 +0000)]
Merge "Avoid page_touched update for HTTP GET action=purge requests"
jenkins-bot [Tue, 13 Sep 2016 05:43:09 +0000 (05:43 +0000)]
Merge "Make DeferredUpdates call setTransactionTicket() on all DataUpdate tasks"
jenkins-bot [Tue, 13 Sep 2016 05:31:47 +0000 (05:31 +0000)]
Merge "Parser: Allow disabling magic link functionality"
jenkins-bot [Tue, 13 Sep 2016 05:30:13 +0000 (05:30 +0000)]
Merge "SkinTemplate: Improve remote content handling in content navigation URLs"
Aaron Schulz [Sun, 11 Sep 2016 18:49:42 +0000 (11:49 -0700)]
Avoid page_touched update for HTTP GET action=purge requests
This will still clear the local DC parser cache and the CDN cache
in all DCs. Therefore, the next page views served by the local
DC will reflect the refreshed content, as will further GET/HEAD
requests by the client that issued the purge using GET/HEAD.
If the problem was imply a stale CDN cache entry, then all
DCs will be up-to-date. If the problem is stale parser cache,
then a proper POST purge request is required to refresh all DCs.
Bug: T92357
Change-Id: I9af12ca8cfff73298f404fd3e2dd4f546621c546
jenkins-bot [Tue, 13 Sep 2016 05:23:28 +0000 (05:23 +0000)]
Merge "Add WikiPage::isLocal()"
jenkins-bot [Tue, 13 Sep 2016 05:21:04 +0000 (05:21 +0000)]
Merge "LocalIdLookup: Use DBAccessObjectUtils"
jenkins-bot [Tue, 13 Sep 2016 05:16:30 +0000 (05:16 +0000)]
Merge "CentralIdLookup: Fix documentation of self::$instances"
jenkins-bot [Tue, 13 Sep 2016 05:12:13 +0000 (05:12 +0000)]
Merge "session: Fix phpdoc in Token::toStringAtTimestamp()"
jenkins-bot [Tue, 13 Sep 2016 05:06:23 +0000 (05:06 +0000)]
Merge "WikiPage: Use Title::isKnown() in hasViewableContent()"
Kunal Mehta [Tue, 13 Sep 2016 04:43:56 +0000 (21:43 -0700)]
SkinTemplate: Improve remote content handling in content navigation URLs
Use Title::isKnown() to determine whether to display the "view" view link
instead of checking $isForeignFile, since that includes all remote
content. This allows us to remove the GlobalUserPage hook that made the
tab look as if it existed.
Change-Id: Ibee7b64511fba8c2934da3c7a3bdd52090dcb58c
jenkins-bot [Tue, 13 Sep 2016 05:02:22 +0000 (05:02 +0000)]
Merge "Use late static binding in Article::newFromID()"
Kunal Mehta [Fri, 9 Sep 2016 07:28:49 +0000 (00:28 -0700)]
Parser: Allow disabling magic link functionality
The magic link functionality is "old backwards-compatibility baggage"
that we probably want to get rid of eventually. The first step to doing
so would be making it configurable and allowing it to be turned off on
wikis that don't use it.
This adds each of the 3 magic link types as individual parser options,
which can be controlled by the $wgEnableMagicLinks setting.
Additionally, wfEscapeWikiText() was updated to only escape enabled
magic link types.
Bug: T47942
Change-Id: If63965f31d17da4b864510146e0018da1cae188c
jenkins-bot [Tue, 13 Sep 2016 04:58:02 +0000 (04:58 +0000)]
Merge "MapCacheLRU: Support null values in getWithSetCallback()"
Kunal Mehta [Tue, 13 Sep 2016 04:32:53 +0000 (21:32 -0700)]
Add WikiPage::isLocal()
WikiFilePage has a isLocal() function which indicates whether the file
is local or not. To better support other remote content, add this method
to the base WikiPage class. It only returns true currently, since all
content represented by WikiPage is local.
Change-Id: Ia39c405af4d131d919a57512e72a112bd65cc461
Aaron Schulz [Tue, 13 Sep 2016 04:48:51 +0000 (21:48 -0700)]
Make DeferredUpdates call setTransactionTicket() on all DataUpdate tasks
This assues that things like LinksUpdate/LinksDeletionUpdate will
have a proper ticket for commitAndWaitForReplication()
Change-Id: I8234510efb706394c39c4027ddf54ace76983aa9
Kunal Mehta [Tue, 13 Sep 2016 04:29:41 +0000 (21:29 -0700)]
LocalIdLookup: Use DBAccessObjectUtils
This simplies some code that was re-implementing
DBAccessObjectUtils::getDBOptions().
Change-Id: Ib446f43149abdf23f07f209ccd9698923f0a2c22
Kunal Mehta [Tue, 13 Sep 2016 04:29:09 +0000 (21:29 -0700)]
CentralIdLookup: Fix documentation of self::$instances
Change-Id: I9fd86c174832e130647e74f4fdeb9fdc7c90702e
Kunal Mehta [Tue, 13 Sep 2016 04:27:50 +0000 (21:27 -0700)]
session: Fix phpdoc in Token::toStringAtTimestamp()
Change-Id: I35664eb9e89ffb945eb35bf3af58e1efdea0a8ff
Kunal Mehta [Tue, 13 Sep 2016 04:27:25 +0000 (21:27 -0700)]
WikiPage: Use Title::isKnown() in hasViewableContent()
The current implementation of hasViewableContent() is basically the same
as Title::isKnown(), except that it switched the order of
isAlwaysKnown() and exists(). (Also it used WikiPage::exists() instead
of Title::exists(), but they're functionality equivalent).
This will make refactoring Title::isAlwaysKnown() easier in the future
as there is one less caller.
Change-Id: I698f08fb0f3e6c3bc702ec7d523d7eda063e18ca
Kunal Mehta [Tue, 13 Sep 2016 04:24:50 +0000 (21:24 -0700)]
Use late static binding in Article::newFromID()
Address the FIXME and remove subclass implementations by using late
static binding.
Change-Id: I4f1793c87dfe08f768a283128d14ee2226a9e275
Kunal Mehta [Tue, 13 Sep 2016 04:23:09 +0000 (21:23 -0700)]
MapCacheLRU: Support null values in getWithSetCallback()
The rest of this class supports having a key with a null value by using
array_key_exists() instead of isset(). So Use $this->has() in
getWithSetCallback() so a null value is still identified as set.
Change-Id: Ida74a6f7e284e98f9a7d76d97312ebe2ee343f10
jenkins-bot [Tue, 13 Sep 2016 04:39:50 +0000 (04:39 +0000)]
Merge "Reorganize RefreshLinksJob code slightly and avoid deprecated functions"
jenkins-bot [Tue, 13 Sep 2016 04:38:38 +0000 (04:38 +0000)]
Merge "Tweak $wgTrxProfilerLimits to lower noise a bit"
Aaron Schulz [Tue, 13 Sep 2016 03:31:05 +0000 (20:31 -0700)]
Remove pointless double exception logging from JobRunner
Change-Id: I12a2e6db326af25a3a276a477fbff505feac87b6
jenkins-bot [Tue, 13 Sep 2016 04:33:26 +0000 (04:33 +0000)]
Merge "Make safeWaitForMasterPos() use mWaitTimeout instead of hard-coded value"
jenkins-bot [Tue, 13 Sep 2016 04:27:03 +0000 (04:27 +0000)]
Merge "Avoid using deprecated methods in JobQueueDB"
jenkins-bot [Tue, 13 Sep 2016 04:25:29 +0000 (04:25 +0000)]
Merge "Remove pointless getTransactionProfiler() method"
Aaron Schulz [Sun, 11 Sep 2016 12:19:57 +0000 (05:19 -0700)]
Make DeferredUpdates::execute() protected
Update the only caller, which is a deprecated wrapper method.
Locking down this internal method makes it secure against
misuse with regards to recursion checks.
Change-Id: I3ed52dbe4c0ad52c7b5de92e81bfdc98a1737bcf
Aaron Schulz [Tue, 13 Sep 2016 04:11:11 +0000 (21:11 -0700)]
Reorganize RefreshLinksJob code slightly and avoid deprecated functions
Change-Id: I6ff4bec61b37bfbffc1e96eac61d692dd7feb31a
Aaron Schulz [Tue, 13 Sep 2016 03:44:19 +0000 (20:44 -0700)]
Simplify LBFactory ticket code in CategoryMembershipChangeJob
Change-Id: I5800bbf6fa718604ffa12d8cde1aa3675fced6fd
jenkins-bot [Tue, 13 Sep 2016 03:24:34 +0000 (03:24 +0000)]
Merge "Update Bugzilla references to Phabricator references"
Aaron Schulz [Tue, 13 Sep 2016 02:56:37 +0000 (19:56 -0700)]
Avoid using deprecated methods in JobQueueDB
Change-Id: Ib35b8792e3e4902b52c3e708d8c6e756f35986bd
Aaron Schulz [Tue, 13 Sep 2016 02:56:09 +0000 (19:56 -0700)]
Remove pointless getTransactionProfiler() method
Change-Id: Ib019e8317568105b95138cfdc0962b06a55154b9
Aaron Schulz [Tue, 13 Sep 2016 02:13:38 +0000 (19:13 -0700)]
Tweak $wgTrxProfilerLimits to lower noise a bit
Change-Id: I22ae7a5c2ba5f39007019e47ea0dff17a4cc971a
jenkins-bot [Tue, 13 Sep 2016 01:31:28 +0000 (01:31 +0000)]
Merge "Make LBFactory::waitForReplication() mask wait latency with callbacks"
jenkins-bot [Tue, 13 Sep 2016 01:27:59 +0000 (01:27 +0000)]
Merge "Avoid creating DB replication lag in clearAllNotifications()"
jenkins-bot [Tue, 13 Sep 2016 00:46:42 +0000 (00:46 +0000)]
Merge "EditPage: Don't throw exceptions for invalid content models"
jenkins-bot [Tue, 13 Sep 2016 00:38:14 +0000 (00:38 +0000)]
Merge "Allow putting the app ID in the password for bot passwords"
Aaron Schulz [Wed, 24 Aug 2016 21:22:11 +0000 (14:22 -0700)]
Support masking the WRITE_SYNC latency from ChronologyProtector
* Use OutputPage::output() as the method to mask latency, since it
takes a good while to run. By the time it runs, cache replication
should have caught up, so the reap call will likely not block.
* For redirects emitted after changes in POST, instead of masking
with OutputPage, add a parameter to the redirect and block on
the positions appearing. This uses the redirection RTT to mask
the replication latency.
Change-Id: Ib23690c302e8033610fef9a0ef451dafe8a5803e
Aaron Schulz [Mon, 12 Sep 2016 23:46:02 +0000 (16:46 -0700)]
Make LBFactory::waitForReplication() mask wait latency with callbacks
This simply moves the call order down a bit.
Change-Id: I78559f769133d5addb590a65af7d535604de8407
Gergő Tisza [Thu, 8 Sep 2016 22:10:19 +0000 (22:10 +0000)]
Fix some PhpStorm warnings in AuthManager
Change-Id: Ib5fab7a54a6572897d9b679d6470d830cbb3cea9
jenkins-bot [Mon, 12 Sep 2016 22:21:50 +0000 (22:21 +0000)]
Merge "WebRequest: Use getRawVal instead of getGPCVal where possible"
jenkins-bot [Mon, 12 Sep 2016 22:20:20 +0000 (22:20 +0000)]
Merge "Make JobQueueGroup::push() update the queuesHaveJobs() cache"
jenkins-bot [Mon, 12 Sep 2016 22:11:14 +0000 (22:11 +0000)]
Merge "Add structure test for ContentHandler::makeEmptyContent()"
Kunal Mehta [Mon, 12 Sep 2016 09:52:51 +0000 (02:52 -0700)]
EditPage: Don't throw exceptions for invalid content models
If a user tries to use an unrecognized content model using the "model"
request parameter, show a nice, localized error instead of an exception.
Bug: T145367
Change-Id: I50e7d332727c9afc22c1658d32c981db4305185b
Aaron Schulz [Mon, 12 Sep 2016 21:23:14 +0000 (14:23 -0700)]
Make sure emails from RecentChange::save() are for comitted rows
Change-Id: I9086a70348d2f0843527e3805e9f6aef3356ee03
Aaron Schulz [Mon, 12 Sep 2016 20:57:22 +0000 (13:57 -0700)]
Make safeWaitForMasterPos() use mWaitTimeout instead of hard-coded value
Change-Id: Idd5db66f5e7cea9fc3f3a4f47bd38e08e42559f6
Ed Sanders [Mon, 12 Sep 2016 20:50:46 +0000 (13:50 -0700)]
Follow-up
dfd0464: Remove LICENSE.txt for deleted library 'phpjs-sha1'
Change-Id: Ia4bbd23c2e78eea9277dc8b1ade8bd3345559c9a
Translation updater bot [Mon, 12 Sep 2016 20:18:47 +0000 (22:18 +0200)]
Localisation updates from https://translatewiki.net.
Change-Id: I634a673bf12cc66b2fbffb9a3abd2a2a0237ebe4
Roan Kattouw [Mon, 12 Sep 2016 18:50:34 +0000 (11:50 -0700)]
momentjs: Hack around bug in node/browser compat wrapper in locale files
If there is an element with id="global" on the page,
typeof global !== 'undefined' is true, but global.moment will
still be undefined and shouldn't be used.
For now, comment out the wrapper and just use 'this'.
We should look into upgrading to momentjs 2.14 where this bug is fixed.
Bug: T145382
Change-Id: Ia6e3b46e42248a5ee3c61c5fcda7d020d012e89e
jenkins-bot [Mon, 12 Sep 2016 15:39:48 +0000 (15:39 +0000)]
Merge "mw.special.movePage: Don't fail if no "Move associated talk page" checkbox"
jenkins-bot [Mon, 12 Sep 2016 15:33:10 +0000 (15:33 +0000)]
Merge "Add missing dependency to 'mediawiki.Upload.BookletLayout' module"
jenkins-bot [Mon, 12 Sep 2016 15:30:23 +0000 (15:30 +0000)]
Merge "Sync up with Parsoid parserTests."
jenkins-bot [Mon, 12 Sep 2016 15:26:34 +0000 (15:26 +0000)]
Merge "Change file namespace name & and specialpages titles in Urdu"
Subramanya Sastry [Mon, 12 Sep 2016 14:06:04 +0000 (09:06 -0500)]
Sync up with Parsoid parserTests.
This now aligns with Parsoid commit
94316242479f272b51db431a0f8fb6d77bd8f639
Change-Id: I411e3b733f4f1e5da5fa2500354575af77e09c88
محمد شعیب [Thu, 8 Sep 2016 08:42:26 +0000 (08:42 +0000)]
Change file namespace name & and specialpages titles in Urdu
It is requested by Urdu Wikipedia community that file namespace should be changed from "ملف:" to "فائل:", and hence need to change all those special page names where "ملف" word is being used and change to word "فائل". Plus some minor corrections.
Bug: T144437
Change-Id: I09070412fa7f3ce98520704ae60c660c682018e5
Bartosz Dziewoński [Mon, 12 Sep 2016 13:04:39 +0000 (15:04 +0200)]
Add missing dependency to 'mediawiki.Upload.BookletLayout' module
Bug: T145315
Change-Id: Idadbf3adf4a145530774abc5fc8cf5fe4920330d
Aaron Schulz [Mon, 12 Sep 2016 13:01:04 +0000 (06:01 -0700)]
Avoid creating DB replication lag in clearAllNotifications()
Change-Id: Ifad51cf2aaa9867513615d48753436cf686d7f1c
jenkins-bot [Mon, 12 Sep 2016 12:33:59 +0000 (12:33 +0000)]
Merge "add IGNORE INDEX option to mysql database handler"
jenkins-bot [Mon, 12 Sep 2016 10:24:54 +0000 (10:24 +0000)]
Merge "Make WikiPage::doPurge() clear the file cache too"
jenkins-bot [Mon, 12 Sep 2016 10:22:16 +0000 (10:22 +0000)]
Merge "Make PurgeJobUtils avoid creating DB replication lag"
jenkins-bot [Mon, 12 Sep 2016 10:15:58 +0000 (10:15 +0000)]
Merge "Clean up array() syntax from docs, part VI"
Amir Sarabadani [Mon, 12 Sep 2016 10:06:37 +0000 (14:36 +0430)]
Clean up array() syntax from docs, part VI
Change-Id: Ib0eea494e2065c7ab356dc45fd174544a9c1c942
jenkins-bot [Mon, 12 Sep 2016 09:59:52 +0000 (09:59 +0000)]
Merge "Improve compatibility checks in WaitConditionLoop"
Aaron Schulz [Mon, 12 Sep 2016 09:47:06 +0000 (02:47 -0700)]
Improve compatibility checks in WaitConditionLoop
* Check if getrusage() is not defined.
* Assume worse-case CPU usage in such cases to avoid spin loops.
* Move these checks to the constructor so they only happen once.
Change-Id: I180629c17b3323e8841a25c2d920390116ae6b74
jenkins-bot [Mon, 12 Sep 2016 09:34:23 +0000 (09:34 +0000)]
Merge "Special:UserRights: Trim value of $mTarget if it's a string"
Geoffrey Mon [Tue, 22 Dec 2015 20:48:19 +0000 (15:48 -0500)]
Add day to date filter for ReverseChronologicalPager
* ReverseChronologicalPager::getDateCond now accepts a day parameter
* Make year parameter of getDateCond optional (current year used)
* Make month parameter of getDateCond optional (end of year used)
* Tests for ReverseChronologicalPager::getDateCond
Depends-On: I587f1f4402ba2964ff23c0d4b06e41accbe05c10
Bug: T120733
Change-Id: I8e684f067d792b07137341d63cd2e54a18c51a7d
Tim Starling [Mon, 12 Sep 2016 06:43:38 +0000 (16:43 +1000)]
parserTests.php: Fix exit status
The return value of Maintenance::execute() is discarded, not used as an
exit status.
Change-Id: I9dd92e43b5b1df1a63d0e8302d360d0bb0f57e7b
Tim Starling [Mon, 12 Sep 2016 06:29:24 +0000 (16:29 +1000)]
Release notes for parser tests refactor
Change-Id: Ic5cd1e368067024bd264ae991d04f61c58535cd1
Tim Starling [Thu, 8 Sep 2016 01:25:22 +0000 (11:25 +1000)]
Refactor parser tests
Merge the PHPUnit parser test runner with the old parserTests.inc,
taking the good bits of both. Reviewed, pared down and documented the
setup code. parserTests.php is now a frontend to a fully featured
parser test system, with lots of developer options, whereas PHPUnit
provides a simpler interface with increased isolation between test
cases.
Performance of both frontends is much improved, perhaps 2x faster for
parserTests.php and 10x faster for PHPUnit.
General:
* Split out the pre-Setup.php global variable configuration from
phpunit.php into a new class called TestSetup, also called it from
parserTests.php.
* Factored out the setup of TestsAutoLoader into a static method in
Maintenance.
* In Setup.php improved "caches" debug output.
PHPUnit frontend:
* Delete the entire contents of NewParserTest and replace it with a
small wrapper around ParserTestRunner. It doesn't inherit from
MediaWikiTestCase anymore since integrating the setup code was an
unnecessary complication.
* Rename MediaWikiParserTest to ParserTestTopLevelSuite and made it an
instantiable TestSuite class instead of just a static method. Got rid
of the eval(), just construct TestCase objects directly with a
specified name, it works just as well.
* Introduce ParserTestFileSuite for per-file setup.
* Remove parser-related options from phpunit.php, since we don't
support them anymore. Note that --filter now works just as well as
--regex used to.
* Add CoreParserTestSuite, equivalent to ExtensionsParserTestSuite,
for clarity.
* Make it possible to call MediaWikiTestCase::setupTestDB() more than
once, as is implied by the documentation.
parserTests.php frontend:
* Made parserTests.php into a Maintenance subclass, moved CLI-specific
code to it.
* Renamed ParserTest to ParserTestRunner, this is now the generic
backend.
* Add --upload-dir option which sets up an FSFileBackend, similar
to the old default behaviour
Test file reading and interpretation:
* Rename TestFileIterator to TestFileReader, and make it read and buffer
an entire file, instead of iterating.
* The previous code had an associative array representation of test
specifications. Used this form more widely to pass around test data.
* Remove the idea of !!hooks copying hooks from $wgParser, this is
unnecessary now that all extensions use ParserFirstCallInit. Resurrect
an old interpretation of the feature which was accidentally broken: if
a named hook does not exist, skip all tests in the file.
* Got rid of the "subtest" idea for tidy variants, instead use a
human-readable description that appears in the output.
* When all tests in a file are filtered or skipped, don't create the
articles in them. This greatly speeds up execution time when --regex
matches a small number of tests. It may possibly break extensions, but
they would have been randomly broken anyway since there is no
guarantee of test file execution order.
* Remove integrated testing of OutputPage::addCategoryLinks() category
link formatting, life is complicated enough already. It can go in
OutputPageTest if that's a thing we really need.
Result recording and display:
* Make TestRecorder into a generic plugin interface for progress output
etc., which needs to be abstracted for PHPUnit integration.
* Introduce MultiTestRecorder for recorder chaining, instead of using
a long inheritance chain. All test recorders now directly inherit from
TestRecorder.
* Move all console-related code to the new ParserTestPrinter.
* Introduce PhpunitTestRecorder, which is the recorder for the PHPUnit
frontend. Most events are ignored since they are never emitted in the
PHPUnit frontend, which does not call runTests().
* Put more information into ParserTestResult and use it more often.
Setup and teardown:
* Introduce a new API for setup/teardown where setup functions return a
ScopedCallback object which automatically performs the corresponding
teardown when it goes out of scope.
* Rename setUp() to staticSetup(), rewrite. There was a lot of cruft in
here which was simply copied from Setup.php without review, and had
nothing to do with parser tests.
* Rename setupGlobals() to perTestSetup(), mostly rewrite. For
performance, give staticSetup() precedence in cases where they were
both setting up the same thing.
* In support of merged setup code, allow Hooks::clear() to be called
from parserTests.php.
* Remove wgFileExtensions -- it is only used by UploadBase which we
don't call.
* Remove wgUseImageResize -- superseded by MockMediaHandlerFactory which
I imported from NewParserTest.
* Import MockFileBackend from NewParserTest. But instead of
customising the configuration globals, I injected services.
* Remove thumbnail deletion from upload teardown. This makes glob
handling as in the old parserTests.php unnecessary.
* Remove math file from upload teardown, math is actually an extension
now! Also, the relevant parser tests were removed from the Math
extension two years ago in favour of unit tests.
* Make addArticle() private, and introduce addArticles() instead, which
allows setup/teardown to be done once for each batch of articles
instead of every time.
* Remove $wgNamespaceAliases and $wgNamespaceProtection setup. These were
copied in from Setup.php in 2010, and are redundant since we do
actually run Setup.php.
* Use NullLockManager, don't set up a temporary directory just for
this alone.
Fuzz tests:
* Use the new TestSetup class.
* Updated for ParserTestRunner interface change.
* Remove some obsolete references to fuzz tests from the two frontends
where they used to reside.
Bug: T41473
Change-Id: Ia8e17008cb9d9b62ce5645e15a41a3b402f4026a
Tim Starling [Thu, 8 Sep 2016 01:07:06 +0000 (11:07 +1000)]
Renames preparatory to parser tests refactor
Since in several cases, with an all-in-one commit, git's file rename
detection failed, I split the renames out into their own commit to
make review easier. Some changes here won't make complete sense without
the following commit.
* Moved TestsAutoLoader to tests/common/. It will be joined by a friend.
* Renamed ParserTest to ParserTestRunner, since the former name was
overly generic.
* Renamed TestFileIterator to TestFileReader. Please see the subsequent
commit for rationale.
* Moved parserTests.php to tests/parser/. It was the only file left in
tests/, and it should have been moved to tests/parser years ago,
analogous to phpunit.php.
* Renamed NewParserTest to ParserIntegrationTest. This was a tricky one,
apparently the name has to end in "Test" or else the structure test
will fail. Analogous to ParserMethodsTest etc. Rationale: because it's
not new anymore.
* Renamed MediaWikiParserTest to ParserTestTopLevelSuite and moved it to
the suites directory. A more descriptive name. Being in suites/
shields it from StructureTests, and is correct anyway.
Change-Id: Iddc6eaf815fdd64b3addb8570b4b6303ab99d634
Aaron Schulz [Mon, 12 Sep 2016 03:46:43 +0000 (20:46 -0700)]
Avoid "No transaction is active" saveFileDependencies() tests errors
Unit tests run in CLI mode without DBO_TRX
Change-Id: Icee9cf84cb9e057b329dd3960fcc9b238af478a3